fix: [PR-1911] avoid recursive sf upgrade calls#246
Merged
sigmachirality merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
…upgrade execution When auto-upgrade triggered 'sf upgrade', the nested process could trigger another auto-upgrade check, causing process management issues. Now we set SF_CLI_DISABLE_AUTO_UPGRADE=1 when calling 'sf upgrade' and re-running the original command to prevent this recursion. Co-authored-by: Daniel Tao <danieltaox@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
Review changes with |
sigmachirality
changed the title
sf upgrade calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
SF_CLI_DISABLE_AUTO_UPGRADEenvironment variable to prevent recursive auto-upgrade checks.The auto-upgrade process was calling
sf upgradewhich could trigger another auto-upgrade check, leading to recursion and process management issues. Setting this environment variable ensures that nestedsf upgradecalls do not re-trigger the auto-upgrade logic.Slack Thread